Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix item trashed event #3083

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Fix item trashed event #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0ad0ff
Fix resource ID in the ItemTrashed events
aduffeck Jul 18, 2022
883bd8e
Add changelog
aduffeck Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-item-trashed-event.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Add space id to ItemTrashed event

We fixed the resource IDs in the ItemTrashed events which were missing the
recently introduced space ID in the resource ID.

https://github.com/cs3org/reva/pull/3083
1 change: 1 addition & 0 deletions internal/grpc/interceptors/eventsmiddleware/conversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ func ItemTrashed(r *provider.DeleteResponse, req *provider.DeleteRequest, execut
Ref: req.Ref,
ID: &provider.ResourceId{
StorageId: req.Ref.GetResourceId().GetStorageId(),
SpaceId: req.Ref.GetResourceId().GetSpaceId(),
OpaqueId: opaqueID,
},
}
Expand Down