Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add userid matching #3096

Merged
merged 9 commits into from
Jul 27, 2022
Merged

add userid matching #3096

merged 9 commits into from
Jul 27, 2022

Conversation

dragonchaser
Copy link

@dragonchaser dragonchaser commented Jul 21, 2022 •
edited
Loading

We fixed the user filter to display the users drives properly and allow admins to list other users drives.

refs owncloud/ocis#4072

@dragonchaser dragonchaser requested a review from a team as a code owner July 21, 2022 15:11
@update-docs
Copy link

update-docs bot commented Jul 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser marked this pull request as draft July 21, 2022 15:13
kobergj
kobergj requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some clarification. Rest looks good 👍

pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
@kobergj
Copy link
Contributor

kobergj commented Jul 22, 2022

Sorry. Github wrote email I should review. Didn't realize it's on draft. Ignore comments if they are still worked on.

@dragonchaser
Copy link
Author

Sorry. Github wrote email I should review. Didn't realize it's on draft. Ignore comments if they are still worked on.

no problem, input during dev is also valuable :)

@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2022

This pull request fixes 1 alert when merging 165737b into b832b4c - view on LGTM.com

fixed alerts:

  • 1 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request fixes 1 alert when merging 0305f2d into c11d954 - view on LGTM.com

fixed alerts:

  • 1 for Uncontrolled data used in path expression

@dragonchaser dragonchaser force-pushed the fix-user-filter branch 2 times, most recently from 0062513 to c7c5580 Compare July 25, 2022 13:46
@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request fixes 1 alert when merging c7c5580 into c11d954 - view on LGTM.com

fixed alerts:

  • 1 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jul 26, 2022

This pull request fixes 1 alert when merging fddcafb into c11d954 - view on LGTM.com

fixed alerts:

  • 1 for Uncontrolled data used in path expression

@dragonchaser dragonchaser force-pushed the fix-user-filter branch 2 times, most recently from fc54cd1 to 0f86928 Compare July 27, 2022 08:19
@dragonchaser
add userid matching
c470b97 
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser
add changelog
796fb83 
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser
fix user filter
9357e08 
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser
introduce userIDAny as constant
e789fb9 
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser
add missing function comments
c9538b7 
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser
add missing interfaces to storage.go
3172a19 
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser @aduffeck
add test struct
aeed5e8 
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: André Duffeck <andre.duffeck@firondu.de>
@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request fixes 1 alert when merging aeed5e8 into 35c5f86 - view on LGTM.com

fixed alerts:

  • 1 for Uncontrolled data used in path expression

@dragonchaser @aduffeck
Refactor env.Fs into decomposedfs
86682b3 
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Andé Duffeck <andre.duffeck@firondu.de>
@dragonchaser
remove obsolete switch branch
299db15 
Signed-off-by: Christian Richter <crichter@owncloud.com>
kobergj
kobergj approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragonchaser dragonchaser marked this pull request as ready for review July 27, 2022 11:17
@dragonchaser dragonchaser merged commit 29f9f53 into cs3org:edge Jul 27, 2022
@dragonchaser dragonchaser mentioned this pull request Jul 27, 2022
Merged
@dragonchaser dragonchaser deleted the fix-user-filter branch July 28, 2022 11:27
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonchaser @kobergj