Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override default broker for micro #3233

Merged
merged 1 commit into from
Sep 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/ocdav-broker-conf.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Allow to override default broker for go-micro base ocdav service

An option for setting an alternative go-micro Broker was introduced. This can
be used to avoid ocdav from spawing the (unneeded) default http Broker.

https://github.com/cs3org/reva/pull/3233
9 changes: 9 additions & 0 deletions pkg/micro/ocdav/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"github.com/cs3org/reva/v2/internal/http/services/owncloud/ocdav"
"github.com/cs3org/reva/v2/pkg/storage/favorite"
"github.com/rs/zerolog"
"go-micro.dev/v4/broker"
)

// Option defines a single option function.
Expand All @@ -33,6 +34,7 @@ type Option func(o *Options)
// Options defines the available options for this package.
type Options struct {
TLSConfig *tls.Config
Broker broker.Broker
Address string
Logger zerolog.Logger
Context context.Context
Expand Down Expand Up @@ -70,6 +72,13 @@ func TLSConfig(config *tls.Config) Option {
}
}

// Broker provides a function to set the Broker option.
func Broker(b broker.Broker) Option {
return func(o *Options) {
o.Broker = b
}
}

// Address provides a function to set the address option.
func Address(val string) Option {
return func(o *Options) {
Expand Down
1 change: 1 addition & 0 deletions pkg/micro/ocdav/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ func Service(opts ...Option) (micro.Service, error) {
sopts.Logger = sopts.Logger.With().Str("name", sopts.Name).Logger()

srv := httpServer.NewServer(
server.Broker(sopts.Broker),
server.TLSConfig(sopts.TLSConfig),
server.Name(sopts.Name),
server.Address(sopts.Address), // Address defaults to ":0" and will pick any free port
Expand Down