Further improve lock contention #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
force-pushed
the
improve-lock-contention2
branch
4 times, most recently
from
db18fb5 to
bf4a13e
Compare
aduffeck
force-pushed
the
improve-lock-contention2
branch
7 times, most recently
from
2e5e45f to
5a6a954
Compare
The cache functions as a request-level xattr cache and reduces the number of *xattr syscalls being made.
aduffeck
force-pushed
the
improve-lock-contention2
branch
from
5a6a954 to
d571de9
Compare
aduffeck
changed the title
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
kobergj
requested changes
Nov 7, 2022
kobergj
approved these changes
Nov 8, 2022
Comment on lines
-985
to
-987
| if xattrs.IsAttrUnset(err) { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This attrunset check is also removed. Not sure if this is critical
There was a problem hiding this comment.
This error is only logged further up the stack, and it shouldn't occur in the first place.
73 tasks
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces lock contention by adding a xattr write-through cache for nodes.
The cache functions as a request-level xattr cache and reduces the number of *xattr syscalls being made.