Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating to internal link #3436

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Allow updating to internal link #3436

merged 3 commits into from
Nov 9, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Nov 7, 2022

Allow updating a link to a private link. See owncloud/ocis#4979

@kobergj
Copy link
Contributor Author

kobergj commented Nov 7, 2022 •
edited
Loading

@micbar could you check my solution? It seems to be a problem of private links vs. denials. Not sure my approach is the perfect one

@kobergj kobergj marked this pull request as draft November 7, 2022 14:49
@kobergj kobergj changed the title Allow updating to private link Allow updating to internal link Nov 7, 2022
@kobergj kobergj force-pushed the UpdateToPrivateLinks branch 2 times, most recently from 240abe4 to bc4dd20 Compare November 7, 2022 15:01
micbar
micbar previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobergj kobergj requested a review from micbar November 8, 2022 09:57
@kobergj
Copy link
Contributor Author

kobergj commented Nov 8, 2022

@micbar needed some more changes to make this work. Please double check

@kobergj kobergj marked this pull request as ready for review November 8, 2022 10:16
@kobergj kobergj dismissed micbar’s stale review November 8, 2022 10:16

major changes since approve

@micbar
Copy link
Member

micbar commented Nov 8, 2022

I cannot get the PR to work locally. The alias link cannot resolve. I am missing the alias=true prop in the response.

@kobergj
allow updating shares to internal links
0f79366 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
changelog
e194fca 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
correctly convert internal links to permission 0
93f33e7 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
Copy link
Contributor Author

kobergj commented Nov 9, 2022

@micbar I needed to pass an islink parameter to the RoleFromResourcePermissions func. That's not nice but it is the only way we can differentiate between "denial" and "internal link".

Please recheck and retest

@micbar
Copy link
Member

micbar commented Nov 9, 2022

Please recheck and retest

Works fine now.

micbar
micbar approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kobergj kobergj merged commit 2b40d49 into cs3org:edge Nov 9, 2022
@kobergj kobergj deleted the UpdateToPrivateLinks branch November 9, 2022 13:57
@kulmann kulmann mentioned this pull request Nov 23, 2022
Closed
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
@ScharfViktor ScharfViktor mentioned this pull request Nov 28, 2022
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobergj @micbar