-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Upload Improvements #3556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
AsyncUploadImprovements
branch
from
December 14, 2022 14:29
be3c8cb
to
231aa93
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
AsyncUploadImprovements
branch
from
December 14, 2022 14:36
231aa93
to
c34a242
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
This reverts commit 1b66f95.
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
AsyncUploadImprovements
branch
from
December 15, 2022 12:51
8b4ddc7
to
b67c767
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
This was referenced Dec 16, 2022
Merged
kobergj
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
December 19, 2022 09:39
Closed
Code is looking fine. Reading the Tests now. |
micbar
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller improvements, tests and leftover from async postprocessing backmerge