Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add correct etag to empty shares jail in propfind responses #3681

Merged
merged 1 commit into from
Feb 27, 2023
Merged

add correct etag to empty shares jail in propfind responses #3681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/shares-propfind-etag.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: fix etag of "empty" shares jail

Added the correct etag for an empty shares jail in PROPFIND responses.

https://github.com/cs3org/reva/pull/3681
https://github.com/owncloud/ocis/issues/5591
2 changes: 1 addition & 1 deletion internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ func (s *service) Stat(ctx context.Context, req *provider.StatRequest) (*provide
}
earliestShare := findEarliestShare(receivedShares, shareMd)
var mtime *typesv1beta1.Timestamp
var etag string
etag := _defaultSharesJailEtag
if earliestShare != nil {
if info, ok := shareMd[earliestShare.GetId().GetOpaqueId()]; ok {
mtime = info.Mtime
Expand Down