Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCM scope and webdav endpoint #3691

Merged
merged 58 commits into from
Mar 7, 2023

Conversation

gmgigi96
Copy link
Member

@gmgigi96 gmgigi96 commented Feb 27, 2023

This PR adds the OCM scope and the ocmshares authentication, to authenticate the federated user to use the OCM shared
resources.
It also adds the (unprotected) webdav endpoint used to interact with the shared resources as described in #2739.

Closes #2739

@gmgigi96 gmgigi96 changed the title Ocm webdav endpoint Add OCM scope and webdav endpoint Mar 2, 2023
@gmgigi96 gmgigi96 marked this pull request as ready for review March 2, 2023 09:09
@gmgigi96 gmgigi96 requested review from labkode, glpatcern and a team as code owners March 2, 2023 09:09
@gmgigi96 gmgigi96 requested a review from wkloucek as a code owner March 6, 2023 14:36
glpatcern
glpatcern previously approved these changes Mar 6, 2023
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for CS3

@glpatcern glpatcern merged commit a4a671d into cs3org:master Mar 7, 2023
gmgigi96 added a commit to gmgigi96/reva that referenced this pull request Jun 28, 2023
* add ocm scope

* add ocmshares authentication

* renamed storage driver for exposing ocm received shares

* implemented storage driver for exposing ocm shares

* register ocm storage providers

* update go-cs3apis

* enable webdav enpoint for ocm

* restrict ocm scope

* set role in ocmshares authentication

* use ocm webdav endpoint for ocm shares

* implemented ocm share get by token in sql driver

* implemented ocm shares get by token in json driver

* add logs to ocmshares auth

* default namespace for ocm webdav

* add logs to ocmshare auth in the webdav layer

* expose get accepted users

* implements get ocm share by token

* suppoprt multiple protocols when downloading

* tests for ocm shares with the webdav endpoint

* use gmgigi fork for go-cs3apis

* fix base path webdav endpoint

* fix stat

* fix stat

* fix on behalf of the owner

* fix config

* fix context passed to auth

* fix owner ctx

* fix2

* run all ops from share creator

* fix download

* run other ops on behalf of share creator

* fix config for tests

* fix resource id

* fix permissions

* fix linter

* fix path traslation for resource ids

* add ocmshares auth creadential strategy

* open /ocs/v1.php/cloud/user to ocmshare scope

* implemented locks in ocm storage driver

* verify in auth layer permissions for locks

* fix tests config

* always do operations on behalf of the share creator

* fix false positive failed tests

* do not change resoure id to enable app collaborations

* check nested resource for ocm shares

* add changelog

* revert integration tests

* update go cs3apis bindings

* fix unit tests

* fix nested resource in scope check

* fix extract ref for ocm scope

* fix permissions on ocm shared resource

* fix ocm user

* fix ocm share role str

* fix linter

* accept path in open in app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCM WebDAV service
2 participants