-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCM scope and webdav endpoint #3691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
previously approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for CS3
glpatcern
approved these changes
Mar 7, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* add ocm scope * add ocmshares authentication * renamed storage driver for exposing ocm received shares * implemented storage driver for exposing ocm shares * register ocm storage providers * update go-cs3apis * enable webdav enpoint for ocm * restrict ocm scope * set role in ocmshares authentication * use ocm webdav endpoint for ocm shares * implemented ocm share get by token in sql driver * implemented ocm shares get by token in json driver * add logs to ocmshares auth * default namespace for ocm webdav * add logs to ocmshare auth in the webdav layer * expose get accepted users * implements get ocm share by token * suppoprt multiple protocols when downloading * tests for ocm shares with the webdav endpoint * use gmgigi fork for go-cs3apis * fix base path webdav endpoint * fix stat * fix stat * fix on behalf of the owner * fix config * fix context passed to auth * fix owner ctx * fix2 * run all ops from share creator * fix download * run other ops on behalf of share creator * fix config for tests * fix resource id * fix permissions * fix linter * fix path traslation for resource ids * add ocmshares auth creadential strategy * open /ocs/v1.php/cloud/user to ocmshare scope * implemented locks in ocm storage driver * verify in auth layer permissions for locks * fix tests config * always do operations on behalf of the share creator * fix false positive failed tests * do not change resoure id to enable app collaborations * check nested resource for ocm shares * add changelog * revert integration tests * update go cs3apis bindings * fix unit tests * fix nested resource in scope check * fix extract ref for ocm scope * fix permissions on ocm shared resource * fix ocm user * fix ocm share role str * fix linter * accept path in open in app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the OCM scope and the ocmshares authentication, to authenticate the federated user to use the OCM shared
resources.
It also adds the (unprotected) webdav endpoint used to interact with the shared resources as described in #2739.
Closes #2739