Support OCM v1.0 schema #3757
Merged
Support OCM v1.0 schema #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
ocm-reconcile
branch
3 times, most recently
from
423c0a8
to
e47f910
Compare
glpatcern
force-pushed
the
ocm-reconcile
branch
2 times, most recently
from
1696e4a
to
33fce17
Compare
glpatcern
force-pushed
the
ocm-reconcile
branch
from
33fce17
to
d5e784b
Compare
gmgigi96
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Can you also update the init script for creating the webapp table? https://github.com/cs3org/reva/blob/master/pkg/ocm/share/repository/sql/init.sql#L72
gmgigi96
approved these changes
Apr 3, 2023
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
* Support OCM v1.0 schema but bail out if the options aren't empty * Fixes following PR comments
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* Support OCM v1.0 schema but bail out if the options aren't empty * Fixes following PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following cs3org/cs3apis#206, we add the fields to ensure backwards compatibility with OCM v1.0.
However, if we receive a request where the
protocol.optionsundocumented object is not empty, we bail out for now. Also, we always send out an emptyprotocol.options, and use the newly defined properties that (will) come with OCM v1.1. This is reflected in the unit tests as well.Supporting interoperability with existing OCM v1.0 implementations (notably Nextcloud 25) may come in the future once the undocumented options are fully reverse engineered.
Also added
viewModeto the webapp protocol and adapted the SQL layer.