Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for password during update public link #3758

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

micbar
Copy link
Member

@micbar micbar commented Mar 28, 2023

Bugfix: Fix public links with enforced password

Fix the public link update operation in the case that a password is enforced.

@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners March 28, 2023 18:50
@micbar micbar requested review from kulmann and kobergj March 28, 2023 18:51
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confused

pkg/publicshare/manager/json/json.go Show resolved Hide resolved
pkg/publicshare/manager/json/json.go Show resolved Hide resolved
@micbar
Copy link
Member Author

micbar commented Mar 29, 2023

confused

I was too at the beginning. Let me explain.

From the backend side, things always look different.

In the web frontend you have the following situation:

  1. You create a link. During that, you cannot specify permissions, it just uses the default and no password
  2. You want to change the permissions to "Editor". Now the Frontend side validation kicks in ans says: "hey, that doesn't work without a password!" and prompts a password. You provide one and violà, we have a request that updates the permissions and the password together. IMO this makes sense.

@micbar micbar requested a review from kobergj March 29, 2023 16:38
@micbar micbar merged commit 1f0e39b into cs3org:edge Mar 30, 2023
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants