Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Makefile error on Ubuntu #3780

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Resolve Makefile error on Ubuntu #3780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5fc105
Fix Makefile error on Ubuntu
MahdiBaghbani Apr 6, 2023
db98793
Create fix-makefile.md
MahdiBaghbani Apr 6, 2023
fc1c7df
Update fix-makefile.md
MahdiBaghbani Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# force makefile to use bash instead of sh.
SHELL := /usr/bin/env bash

.PHONY: all
all: revad reva test-go lint gen-doc

Expand Down
7 changes: 7 additions & 0 deletions changelog/unreleased/fix-makefile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Fix Makefile error on Ubuntu

I've fixed Makefile using sh which is defaulted to dash in ubuntu, dash doesn't support
`[[ ... ]]` syntax and Makefile would throw `/bin/sh: 1: [[: not found` errors.

https://github.com/cs3org/reva/pull/3780
gmgigi96 marked this conversation as resolved.
Show resolved Hide resolved
https://github.com/cs3org/reva/issues/3773