Add prometheus metrics for active transfers. #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
reviewed
Apr 14, 2023
butonic
reviewed
Apr 14, 2023
kobergj
requested changes
Apr 19, 2023
This PR adds simple gauges for active uploads and downloads. These can then be picked up by the prometheus handler.
As there's multiple managers that can upload/download, I moved the metrics to their own package, and added them to all the managers.
Besides the POST, monitor PATCH in tus manager as the upload happens in chunks.
ainmosni
force-pushed
the
ainmosni/feature/dl-ul-metrics
branch
from
7b42674 to
3a38605
Compare
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple gauges for active uploads and downloads. These
can then be picked up by the prometheus handler.