The DeleteStorageSpace method response code has been changed #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
2403905
force-pushed
the
delete-storage-space
branch
from
52ac67e
to
69238ad
Compare
2403905
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
dragonchaser
requested changes
May 5, 2023
2403905
force-pushed
the
delete-storage-space
branch
from
69238ad
to
686b8ec
Compare
dragonchaser
approved these changes
May 8, 2023
kobergj
requested changes
May 8, 2023
| @@ -609,6 +611,10 @@ func (s *service) DeleteStorageSpace(ctx context.Context, req *provider.DeleteSt | |||
| return &provider.DeleteStorageSpaceResponse{ | |||
| Status: st, | |||
| }, nil | |||
| } else if len(spaces) != 1 { | |||
There was a problem hiding this comment.
Suggested change
| } else if len(spaces) != 1 { | |
| } else if len(spaces) == 1 { |
If we need to handle len(spaces) > 1 we should a separate case for it.
2403905
force-pushed
the
delete-storage-space
branch
from
bcb89f5
to
756a843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DeleteStorageSpace method response status has been changed to 'not found' if no one spaces in a list or errtypes.IsNotFound. That allows us to handle the status properly. Related to owncloud/ocis#5031