Dont lose revisions when replacing #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
micbar
approved these changes
May 16, 2023
micbar
requested changes
May 16, 2023
|
@micbar The failing tests expect a file to be turned into a folder when a folder is copied onto (into? over?) them. Is that really the expected behavior here or should we rather adapt the tests? |
|
@aduffeck @individual-it Ok we need to change the test expectations. |
This makes "overwrite when copying" behave the same as "overwrite when uploading". Overwriting when moving a file still deletes the old file (moves it into the trash) and replaces the whole file including the revisions of the source file. Fixes owncloud/ocis#4797
aduffeck
force-pushed
the
dont-lose-revisions-when-replacing
branch
from
f810f49 to
563429e
Compare
micbar
approved these changes
May 23, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer delete-and-upload targets of copy operations but ratheradd a new version with the source content.
This makes "overwrite when copying" behave the same as "overwrite when uploading".
Overwriting when moving a file still deletes the old file (moves it into the trash) and replaces the whole file including the revisions of the source file.
Fixes owncloud/ocis#4797