Remove config for invite_link #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
def-invite-link
branch
from
754fb1f
to
85b8933
Compare
glpatcern
force-pushed
the
def-invite-link
branch
from
85b8933
to
028d0ec
Compare
glpatcern
force-pushed
the
def-invite-link
branch
2 times, most recently
from
bb1ad88
to
580a83f
Compare
gmgigi96
requested changes
Jun 7, 2023
glpatcern
force-pushed
the
def-invite-link
branch
2 times, most recently
from
5dca6ea
to
4760782
Compare
The link template is still defined in a constant but not exposed in the config, as it depends on Mentix and should not be changed.
glpatcern
force-pushed
the
def-invite-link
branch
2 times, most recently
from
380e070
to
71bc43c
Compare
glpatcern
force-pushed
the
def-invite-link
branch
from
71bc43c
to
1d27a97
Compare
gmgigi96
approved these changes
Jun 8, 2023
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* Removed config for invite_link The link template is still defined in a constant but not exposed in the config, as it depends on Mentix and should not be changed. * Updated autogenerated docs * Rephrasing * Removed template and simplified logic for invite URLs * Move config check where it is parsed * Further simplifications * Updated fixtures for integration tests * Updated changelog and example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mini-PR drops invite_link from the OCM-related config.
The link template is still defined in a constant but not exposed in the config, as it depends on Mentix and should not be changed.Edit: the link is not any longer a template and it is instead constructed out of the needed parameters.
Also, the
provider_domainandmesh_directory_urlconfiguration options are now mandatory, and thesciencemeshservice won't start without it.