-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] [full-ci] bump latest commit from ocis #3957
[tests-only] [full-ci] bump latest commit from ocis #3957
Conversation
2438330
to
7d2f69c
Compare
7d2f69c
to
44b2cbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes
44b2cbe
to
4bb85d7
Compare
c078223
to
c8d3714
Compare
https://github.com/cs3org/reva/actions/runs/5241486596/jobs/9463702648?pr=3957
It looks like something is needed to get that |
Need to update cs3org/behat to have the json-assert library |
|
@vascoguita In the test for |
I'm no longer a member of the CERNBox team, so I don't maintain the CI anymore but I suggest you create a PR to cs3org/behat. Once accepted it will build and push the docker image automatically and the CI will update the behat image in use. |
I will make a PR in a few minutes... |
@vascoguita who should I ping to get that approved? |
cs3org/behat#1 has been merged. I requested to rerun the CI jobs. Let's see what happens... |
I would ask @labkode |
It has already been approved and merged, thanks. I am running CI again to get an updated result. Hopefully the merged changes to dependencies "magically" appear in the CI. |
I have bad news for you. It is using the old cached image. I'll ask my old colleagues to clean up the runners and we try again. |
Ok, @gmgigi96 cleaned the runners and now the new behat image is being used. |
This PR bumps the latest commit id from ocis
part of owncloud/QA#811