Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] bump latest commit from ocis #3957

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Jun 8, 2023

This PR bumps the latest commit id from ocis
part of owncloud/QA#811

phil-davis
phil-davis previously approved these changes Jun 9, 2023
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@phil-davis
Copy link
Contributor

https://github.com/cs3org/reva/actions/runs/5241486596/jobs/9463702648?pr=3957

PHP Fatal error:  Trait 'Helmich\JsonAssert\JsonAssertions' not found in /mnt/ocis/tests/acceptance/features/bootstrap/FeatureContext.php on line 51

It looks like something is needed to get that JsonAssertions dependency available to the GitHub workflows CI, or to have test code that does not need it.

@saw-jan
Copy link
Contributor

saw-jan commented Jun 12, 2023

Need to update cs3org/behat to have the json-assert library

@grgprarup
Copy link
Contributor

Need to update cs3org/behat to have the json-assert library

@vascoguita @phil-davis

@PrajwolAmatya
Copy link
Contributor Author

@vascoguita In the test for asserting JSON a package "helmich/phpunit-json-assert": "^3.4" is required, so this cs3org/behat needs to be updated with that package.

@vascoguita
Copy link
Contributor

I'm no longer a member of the CERNBox team, so I don't maintain the CI anymore but I suggest you create a PR to cs3org/behat. Once accepted it will build and push the docker image automatically and the CI will update the behat image in use.

@phil-davis
Copy link
Contributor

I will make a PR in a few minutes...

@phil-davis
Copy link
Contributor

PR cs3org/behat#1

@vascoguita who should I ping to get that approved?

@phil-davis
Copy link
Contributor

cs3org/behat#1 has been merged. I requested to rerun the CI jobs. Let's see what happens...

phil-davis
phil-davis previously approved these changes Jun 12, 2023
@vascoguita
Copy link
Contributor

PR cs3org/behat#1

@vascoguita who should I ping to get that approved?

I would ask @labkode

@phil-davis
Copy link
Contributor

I would ask @labkode

It has already been approved and merged, thanks.

I am running CI again to get an updated result. Hopefully the merged changes to dependencies "magically" appear in the CI.

@vascoguita
Copy link
Contributor

I would ask @labkode

It has already been approved and merged, thanks.

I am running CI again to get an updated result. Hopefully the merged changes to dependencies "magically" appear in the CI.

I have bad news for you. It is using the old cached image. I'll ask my old colleagues to clean up the runners and we try again.
The good news is that the new behat image was successfully built and published: https://hub.docker.com/repository/docker/cs3org/behat/general

@vascoguita
Copy link
Contributor

Ok, @gmgigi96 cleaned the runners and now the new behat image is being used.

@phil-davis phil-davis merged commit 4a502bb into cs3org:master Jun 12, 2023
@phil-davis phil-davis deleted the bump-latest-ocis-commit branch June 12, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants