Allow disabling wopi chat #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
requested review from
labkode,
ishank011,
wkloucek,
glpatcern and
a team
as code owners
wkloucek
reviewed
Jun 16, 2023
pkg/app/provider/wopi/wopi.go
Outdated
Comment on lines
261
to
263
| if p.conf.AppDisableChat { | ||
| urlQuery.Set("dchat", "1") // OnlyOffice disable chat | ||
| } |
There was a problem hiding this comment.
this should be probably be outside of the if language != "" { block, right?
There was a problem hiding this comment.
Yes it should. Thanks!
dj4oC
approved these changes
Jun 16, 2023
Signed-off-by: jkoberg <jkoberg@owncloud.com>
dragonchaser
approved these changes
Jun 16, 2023
9 tasks
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an option to disable chat functionality in wopi apps. Current only supports
OnlyOffice