Dont invalidate metadata cache #4017
Draft
+32
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
approved these changes
Jun 28, 2023
kobergj
requested changes
Jun 28, 2023
aduffeck
force-pushed
the
dont-invalidate-metadata-cache
branch
from
5cc5706 to
09e9d57
Compare
butonic
force-pushed
the
dont-invalidate-metadata-cache
branch
from
33ba4e2 to
eec05ce
Compare
aduffeck
force-pushed
the
dont-invalidate-metadata-cache
branch
from
0bf9b3e to
130bb65
Compare
butonic
force-pushed
the
dont-invalidate-metadata-cache
branch
from
6aafcaa to
1dd27a4
Compare
|
there are some hardcoded chache changes that we want to verify before this PR is ready |
butonic
force-pushed
the
dont-invalidate-metadata-cache
branch
from
b20c8de to
76dbf87
Compare
This was referenced Jul 7, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
dont-invalidate-metadata-cache
branch
from
76dbf87 to
ba857f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some performance tweaks and makes the code more robus when encountering invalid space root metadata.