error msg updated #4216
Merged
error msg updated #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2403905
requested review from
labkode,
ishank011,
a team and
glpatcern
as code owners
2403905
force-pushed
the
OCIS-3809-upd
branch
from
8bb387c to
3d95631
Compare
kobergj
requested changes
Sep 25, 2023
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Show resolved
Hide resolved
kobergj
approved these changes
Sep 25, 2023
|
This broke the testsuite, why was capitalizing the error message necessary? https://drone.owncloud.com/owncloud/ocis/26952/52/6 |
|
IMO we should not manipulate error messages from packages or do any string matching. @2403905 Can we discuss the requirements of the problem? |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.