ldap: fix GetUserByClaim for binary encoded UUIDs #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
GetUserByClaim didn't correctly work for claim "userid" when "idIsOctetString" is set to true. Because the LDAP filter was not correctly hex-escaped. Fixes: owncloud/ocis#7469
rhafer
force-pushed
the
ocisissue/7469
branch
from
31c621e
to
1e86353
Compare
kobergj
approved these changes
Oct 12, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Oct 12, 2023
To get cs3org/reva#4249 Fixes: owncloud#7469
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Oct 12, 2023
To get cs3org/reva#4249 Fixes: owncloud#7469
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Oct 12, 2023
To get cs3org/reva#4249 Fixes: owncloud#7469
rhafer
added a commit
to owncloud/ocis
that referenced
this pull request
Oct 12, 2023
To get cs3org/reva#4249 Fixes: #7469
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetUserByClaim didn't correctly work for claim "userid" when "idIsOctetString" is set to true. Because the LDAP filter was not correctly hex-escaped.
Fixes: owncloud/ocis#7469