bugfix: Role "file-editor" does not have resharing permissions #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to move them to the graph service to get them closer to where they're actually used.
rhafer
force-pushed
the
file-editor-role-resharing
branch
from
5bb5163
to
d7a83f4
Compare
Similar to the generich "editor" role the "file-editor" should have resharing permissions. When creating an "editor" file share using `ocs`. `ocs` already adds the `AddGrant` permission. This commit just about fixing the mapping of resource permission back to the corresponding role.
rhafer
force-pushed
the
file-editor-role-resharing
branch
from
d7a83f4
to
8cc3b38
Compare
|
The bugfix is clear. Why do you remove the unified roles? |
@micbar As mentioned in the commit message on the first commit, I think libregraph specific stuff should not be part of reva so they'd better live with the graph service. See owncloud/ocis@9e50c42 . I am fine revisiting that if people disagree. |
micbar
approved these changes
Nov 14, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Nov 15, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Nov 15, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Nov 15, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Nov 15, 2023
fschade
pushed a commit
to rhafer/ocis
that referenced
this pull request
Nov 16, 2023
fschade
pushed a commit
to rhafer/ocis
that referenced
this pull request
Nov 16, 2023
fschade
added a commit
to owncloud/ocis
that referenced
this pull request
Nov 17, 2023
* bump reva to latest edge To get cs3org/reva#4336 * graph: Import unified role related code from reva The UnifiedRole related types are pretty specific to the graph service. Maintaining them as part of reva makes things more complex that required. * chore: add failing cases to the expected failures --------- Co-authored-by: Florian Schade <f.schade@icloud.com>
ownclouders
pushed a commit
to owncloud/ocis
that referenced
this pull request
Nov 17, 2023
* bump reva to latest edge To get cs3org/reva#4336 * graph: Import unified role related code from reva The UnifiedRole related types are pretty specific to the graph service. Maintaining them as part of reva makes things more complex that required. * chore: add failing cases to the expected failures --------- Co-authored-by: Florian Schade <f.schade@icloud.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the generich "editor" role the "file-editor" should have resharing permissions.
When creating an "editor" file share using
ocs.ocsalready adds theAddGrantpermission. This commit just about fixing the mapping of resource permission back to the corresponding role.