extract UploadSessionLister interface

[butonic]

This is a little cleanup of the UploadProgress interface I had to introduce in #4148

The UploadSessionLister interface allows listing and filtering existing UploadSessions by id, processing or expired state. This can be used by the ocis cli to purge expired AND processed uploads, list uploads that have expired but are still processing etc.

The UploadSession Interface could be extended to include processing steps like the antivirus scan outcome etc, but currently that is stored by the processing service. This may need more thoughts before changing it. I think it makes sense to persist tho outcome of processing steps in the upload session metadata. Unfortunately, we currently store processing stata and scan outcome in the node metadata, not the upload metadata. This will change ofter merging #4148 , then we can think about if and where to persist the processing state ...

For now, I think this PR is ready.

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[aduffeck]

The TODOs and FIXMEs should be addressed or turned into issues before merging this in my opinion, but the general interface looks good to me.
How's the filtering of uploads gonna look like though? Does that become part of the ListUploads() call?

[butonic]

I wonder if ListUploads() should take a filter. one by id to replace GetUploadProgress() and one by status to allow implementing cli tooling that allows listing currently ongoing uploads, uploads that are still in postprocessing to see which ones may have stalle etc. Hm, let me check ifg the graph API has anything interesting...

👀

hm graph uses uploadSessions to represent ongoing uploads ... and the properties expirationDateTime, nextExpectedRanges and uploadUrl are mostly covered by the current interface. ocis / reva actually knows about multiple protocols ... but that is nothing to expose via tha graph api ...

hm

[butonic]

@aduffeck I completely changed the upload interface. I adopted UploadSessions to differentiate it from tus uploads. similar to tus.Info every UploedSession has a Purge() that can be used to completely remove the upload. I don't fully know if we need to emit an event, I think so, but I need to check in which cases.

The ListUploadSessions takes a filter that allows filtering the uploads by expired status, isprocessing flag or id. This allows all current usages and even more granular listing of uploads by the cli.

I also added the antivirus state, which is set during postprocessing. This can be used to list all not yet scanned uploads ...

your opinion?

[butonic]

tracking the tus upload-expires bug in #4379

[aduffeck]

@aduffeck I completely changed the upload interface. ...
your opinion?

lgtm, as discussed in zoom 👍

[kobergj]

Generally looks good but the linter is not happy

Additional Question: Did you run a full-ci pipeline on ocis to make sure these changes don't break ocis pipeline?

[butonic]

@kobergj I hope I made the linter happy ;-) will create an ocis bump right away

[butonic]

ocis pr was green, will rebase #4148 now