Fix recursive trashcan purge #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
fix-recursive-trashcan-purge
branch
from
18136d8
to
afaa3bf
Compare
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
requested review from
a team,
labkode and
glpatcern
as code owners
DeepDiver1975
approved these changes
Feb 21, 2024
butonic
approved these changes
Feb 21, 2024
Merged
|
Thanks for the patch, but unit tests?? There was no coverage, which made this bug possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Fix recursive trashcan purge
We have fixed a bug in the trashcan purge process that did not delete folder structures recursively.
owncloud/ocis#8473