Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill service spanning stat cache #4542

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Mar 1, 2024

We removed the stat cache shared between gateway and storage providers. It is constantly invalidated and needs a different approach.

@butonic butonic requested review from a team, labkode and glpatcern as code owners March 1, 2024 08:43
kobergj
kobergj previously requested changes Mar 1, 2024
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it ❤️ ❤️ ❤️ But since you touched it....

@phil-davis
Copy link
Contributor

CI job "Build Docker / docker (revad:edge-ceph, Dockerfile.revad-ceph)" is failing here, and in #4541
Is that broken in edge branch? Or?

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the kill-service-spanning-stat-cache branch from 3667e41 to 4b1c69a Compare March 1, 2024 10:26
@butonic
Copy link
Contributor Author

butonic commented Mar 1, 2024

@phil-davis I think something broke with the build. Tracked in #4543

@butonic butonic requested a review from kobergj March 1, 2024 11:10
@butonic butonic merged commit c3edaa7 into cs3org:edge Mar 5, 2024
9 checks passed
@butonic butonic deleted the kill-service-spanning-stat-cache branch March 5, 2024 15:30
@micbar micbar mentioned this pull request Jun 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants