Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomposed based posix filesystem driver #4562

Merged
merged 103 commits into from
May 29, 2024

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Mar 6, 2024

This PR adds a new posix fs driver which stores files and metadata directly on a posix compliant directory. It also adds some special handling for gpfs, i.e. for improving the notifications about changes to the underlying data.

It is based on decomposedfs but uses a copy of the lib with some changes that require some refactoring before it can be merged back to the "real" decomposedfs code. We should consider doing this before merging the pr in order to avoid code cuplication.

Supported Features:

  • Personal and project spaces
  • Basic file operations, sharings, previews, etc.
  • "Assimilation" of new data being added to the filesystem bypassing ocis (using either inotifywait, gpfs file audit logs or gpfs watchfolder queues)
  • Handling of changes being made to the files on disk (renaming, moving, etc.)
  • gid mapping (new files/directories will be created with the gid of the space root)

Currently missing:

  • Trashbin support
  • File versioning

Ocis companion PR: owncloud/ocis#8598

Copy link

update-docs bot commented Mar 6, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

This will turn into a pluggable notify module in the future to allow for
making use of fs specific features etc.
This is necessary to update the cached paths for all entries in the
subtree.
@aduffeck aduffeck force-pushed the decomposed-based-posixfs branch 5 times, most recently from 937e4fa to a569602 Compare May 28, 2024 12:21
@aduffeck aduffeck marked this pull request as ready for review May 28, 2024 13:41
@aduffeck aduffeck requested review from a team, labkode and glpatcern as code owners May 28, 2024 13:41
@aduffeck aduffeck changed the title [Draft] Decomposed based posix filesystem driver Decomposed based posix filesystem driver May 28, 2024
@butonic
Copy link
Contributor

butonic commented May 29, 2024

tested with redis started and inotifywait installed using this ocis config:

					"STORAGE_USERS_DRIVER": "posix",
					"STORAGE_USERS_POSIX_ROOT": "/home/jfd/ocis-posix",
					"STORAGE_USERS_ID_CACHE_STORE": "redis",
					"STORAGE_USERS_ID_CACHE_STORE_NODES": "127.0.0.1:6379",

problems noted in owncloud/ocis#8598 (comment)

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no blockers from my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants