Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default create personal space cache store to 'memory' #4621

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Change the default create personal space cache store to 'memory' #4621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a120ab
Change the default create personal space cache store to 'memory'
aduffeck Apr 8, 2024
84e1793
Add changelog
aduffeck Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/change-cache-default-store.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Use a memory cache for the personal space creation cache

Memory is a safe default and ensures that superfluous calls to CreateStorageSpace are prevented.

https://github.com/cs3org/reva/pull/4621
2 changes: 1 addition & 1 deletion internal/grpc/services/gateway/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (c *config) init() {
}

if c.CreatePersonalSpaceCacheConfig.Store == "" {
c.CreatePersonalSpaceCacheConfig.Store = "noop"
c.CreatePersonalSpaceCacheConfig.Store = "memory"
}

if c.CreatePersonalSpaceCacheConfig.Database == "" {
Expand Down
Loading