feat: add secure view share role #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new share role "Secure view". This role only allows viewing resources, no downloading, editing or deleting.
|
@JammingBen Thanks for your first contribution to reva 🎉 Although, i wonder why we need that in reva. IMHO we need that in the ocis graph package. |
|
@micbar Current every role defined in graph (https://github.com/owncloud/ocis/blob/master/services/graph/pkg/unifiedrole/unifiedrole.go) maps to a reva role. Why would it be different for the SecureView role? |
5 tasks
micbar
approved these changes
Apr 22, 2024
kobergj
approved these changes
Apr 22, 2024
pkg/conversions/role.go
Outdated
| @@ -52,6 +52,8 @@ const ( | |||
| RoleUploader = "uploader" | |||
| // RoleManager grants manager permissions on a resource. Semantically equivalent to co-owner. | |||
| RoleManager = "manager" | |||
| // RoleSecureView grants secure view permissions on a resource or space. | |||
| RoleSecureView = "secure-view" | |||
There was a problem hiding this comment.
Are we sure about this naming? I mean "viewer", "editor", "uploader", "manager", ... Shouldn't this be something like "secure-viewer"?
There was a problem hiding this comment.
True, I'll adjust the naming 👍
nirajacharya2
pushed a commit
to JankariTech/reva
that referenced
this pull request
Apr 30, 2024
feat: add secure view share role
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new share role "Secure view". This role only allows viewing resources, no downloading, editing or deleting.
I'm not 100% sure how the exact permissions will end up looking once this role has been refined (see owncloud/ocis#8855), but it's a placeholder to get started.