Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit unneeded ocm request when deleting space shares #4651

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Apr 22, 2024

We no longer check if a share is an ocm sharee if listng ocm shares has been disabled anyway. This saves a request that would fail anyway.

@butonic butonic requested review from labkode, a team and glpatcern as code owners April 22, 2024 11:10
@butonic butonic requested review from aduffeck and removed request for labkode and glpatcern April 22, 2024 11:20
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic changed the title fix deleting space shares omit unneeded ocm request when deleting space shares Apr 26, 2024
@tbsbdr
Copy link

tbsbdr commented May 27, 2024

@butonic is this still needed?

@butonic
Copy link
Contributor Author

butonic commented Aug 1, 2024

yes ... ocis logs during tests are spammed with error level logs

{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"851898bd41c17fc1c35437025848f8a1","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:04:20Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"6f622364c5ff47f71dcfaed0ad0c8f2c","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:31Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"6e96fbda713cc7e52c85197e6bfcc590","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:31Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"9f04b517ff38371228d95030ac62bf56","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:45Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"0c93e71256684e4d5a6373bcb920a181","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:07Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"1d22d5ae5805653e6a9cbc75644ae6a8","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:07Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"e95fc58e15b1439f05233eb0e9f8192f","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:18Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"3400c48c7bc93e3960e2ba00fded7d51","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:30Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"95bb7608c7ce5a58b5ca5b5e6f78d79a","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:06Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"1c0c75a8e2313a59f3433140b663dcf4","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:09Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"e772b9526a0fd8c119c4024822c4349c","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:43Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"9a18a844165d2c2240e2a5162d5194ab","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:05:55Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"1001a0e97f95ae4035ce168d1efd5d50","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:43Z","message":"error calling GetOCMShareProviderClient"}
{"level":"error","service":"gateway","pkg":"rgrpc","traceid":"10b4ced116cd44ba70aa861bf82286ad","error":"com.owncloud.api.ocm: service not found","time":"2024-08-01T15:06:54Z","message":"error calling GetOCMShareProviderClient"}

@butonic butonic force-pushed the fix-deleting-shares branch 2 times, most recently from 84a2ef9 to 5182786 Compare August 2, 2024 14:51
@butonic butonic requested a review from kobergj August 2, 2024 14:51
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic merged commit 1bb14ea into cs3org:edge Aug 6, 2024
9 of 10 checks passed
@butonic butonic deleted the fix-deleting-shares branch August 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants