Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the response code when the role/permission is empty on the share update #4709

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fixed the response code when the role/permission is empty on the share update #4709

merged 1 commit into from
Jun 4, 2024

Conversation

2403905
Copy link

@2403905 2403905 commented Jun 3, 2024 •
edited
Loading

We fixed the response code when the role/permission is empty on the share update

Related issue: owncloud/ocis#8747

@2403905 2403905 requested review from labkode, a team and glpatcern as code owners June 3, 2024 19:07
rhafer
rhafer approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. (Tiny nitpick: For the future it would be good if you linked the fixed issue in the commit message as well)

@2403905 2403905 merged commit ea1516b into cs3org:edge Jun 4, 2024
9 checks passed
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@rhafer rhafer rhafer approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2403905 @rhafer @kobergj