bump go-cs3apis to latest master #4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping this as a draft for now as I need to test it against ocis. |
rhafer
force-pushed
the
ocisissue/9554
branch
9 times, most recently
from
bc96029
to
7d9dd17
Compare
This contains the change that decouples the spaces API from storage API.
The tooling to generate the go bindings has been updated. This cleans up the fallout of that change (e.g. that protobuf messages can no longer be compared reliably with reflect.DeepEqual).
protobuf messages are not supposed to be copied. This changes
the code to use pointers instead. Or proto.Clone() if a copy is
really needed.
Addresss ("copylocks: xxxx passes lock by value ...") issues raised by go-vet
|
There's a draft PR testing this in ocis: owncloud/ocis#9587 |
14 tasks
micbar
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Heroic! 🎉
@glpatcern next time it would be helpful to upgrade the proto tooling in a separate change because that caused a lot of fallout.
This was referenced Jul 29, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed to touch quite a few unit test since the tooling to generate the go bindings was updated to a more recent version. Which causes issues with e.g. using reflect.DeepEqual on proto messages. We're basically running into the changes described here: https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.20.0#v1.20-generated-code