Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blanks in dav Content-Disposition header #4762

Merged

Conversation

JammingBen
Copy link

@JammingBen JammingBen commented Jul 10, 2024

Fixes the encoding of blanks in the dav Content-Disposition header. QueryEscape doesn't encode all special chars like e.g. blanks . Hence we need to use PathEscape.

This is a regression caused by #4748.

See Web issue owncloud/web#11169.

Fixes the encoding of blanks in the dav `Content-Disposition` header.

This is a regression caused by cs3org#4748.
@JammingBen JammingBen force-pushed the fix/blanks-content-disposition-header branch from 8b1a757 to 5940ff5 Compare July 11, 2024 08:19
@JammingBen JammingBen marked this pull request as ready for review July 11, 2024 08:36
@JammingBen JammingBen requested review from labkode, a team and glpatcern as code owners July 11, 2024 08:36
@JammingBen JammingBen merged commit 7dc3c77 into cs3org:edge Jul 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants