-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add folder id and etag to dav mkcol responses #4767
base: edge
Are you sure you want to change the base?
Conversation
Adds the `OC-FileId` and the `OC-ETag` headers to dav `mkcol` responses. This is necessary for clients that work with ids and want to fetch a folder immediately after creating.
503b208
to
48515a7
Compare
I'm not sure this is the correct approach. We would need another stat call, which will impact performance. We should pass the id with the grpc responses so we don't have to call it again. This needs some refactoring, but I still prefer it over the extra stat call. |
Sounds reasonable, could you give me a hint where to start for this? :) Or will this be a more complicated task...? |
We can use an opaque property for now |
Unfortunately not so easy 😢 The decomposedfs method We would need to change the interface and adjust all other implementations. |
Argh ok. Then I'm afraid this is a bit too much for me currently, especially since I don't know how to test all these storage drivers. |
Just for the records: We have the same issue with |
@micbar will you do your IDE magic for the refactor? I volunteer to review it. (Though I'll probably regret that 😉 ) |
Adds the
OC-FileId
and theOC-ETag
headers to davmkcol
responses.This is necessary for clients that work with ids and want to fetch a folder immediately after creating.
fixes owncloud/ocis#9618