fix: dav delete via resource id #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix/dav-delete-via-id
branch
2 times, most recently
from
dcb1326
to
e165045
Compare
|
@kobergj Pinging you specifically for a review because I saw that you touched the initial code a while ago :) |
kobergj
approved these changes
Jul 19, 2024
JammingBen
force-pushed
the
fix/dav-delete-via-id
branch
from
e165045
to
a8b4d97
Compare
Fixes an issue where deleting a resource via its id, using the `/dav/spaces/{fileId}` endpoint, wouldn't work.
The issue was happening because the code was checking for an empty path to prevent spaces from being deleted this way (because spaces have an empty path). When only providing a resource id however, the path will be empty for regular resources as well. For this reason we now additionally check for the resource's `opaqueId`. If the resource doesn't have such or it equals the space id, and the path is empty, then we can assume that it's a space and prevent deletion via the dav endpoint.
JammingBen
force-pushed
the
fix/dav-delete-via-id
branch
from
a8b4d97
to
4b55209
Compare
butonic
approved these changes
Jul 19, 2024
This was referenced Jul 29, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where deleting a resource via its id, using the
/dav/spaces/{fileId}endpoint, wouldn't work.The issue was happening because the code was checking for an empty path to prevent spaces from being deleted this way (because spaces have an empty path). When only providing a resource id however, the path will be empty for regular resources as well. For this reason we now additionally check for the resource's
opaqueId. If the resource doesn't have such and the path is empty, we can assume that it's a space and prevent deletion via the dav endpoint.fixes owncloud/ocis#9619