Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent stat requests when listing shares #4812

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Aug 16, 2024

The sharesstorageprovider now concurrently stats the accepted shares when listing the share jail. The default number of 5 workers can be changed by setting the max_concurrency value in the config map.

fixes owncloud/ocis#9828

with 500 accepted shares on a local machine:

➜  reva git:(edge) http --meta --verify=no -a einstein:relativity PROPFIND https://cloud.ocis.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668 Depth:1
Elapsed time: 0.252219335s

➜  reva git:(sharesstorageprovider-concurrent-stat) http --meta --verify=no -a einstein:relativity PROPFIND https://cloud.ocis.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668 Depth:1
Elapsed time: 0.0148590878s

and on a kubernetes deployment with 200 shares

➜  reva git:(edge) http --meta --verify=no -A bearer -a jwt.data.hash PROPFIND https://cloud.ocis.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668 Depth:1
Elapsed time: 2.7347017197s

➜  reva git:(sharesstorageprovider-concurrent-stat) http --meta --verify=no -A bearer -a jwt.data.hash  PROPFIND https://cloud.ocis.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668 Depth:1
Elapsed time: 0.9289751261s

@butonic butonic requested review from labkode, glpatcern and a team as code owners August 16, 2024 12:50
@butonic butonic self-assigned this Aug 16, 2024
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the sharesstorageprovider-concurrent-stat branch from b53d5bd to c694670 Compare August 16, 2024 13:07
@2403905 2403905 merged commit 2d54572 into cs3org:edge Aug 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants