allow updating of ocm shares #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dragonchaser
changed the title
butonic
reviewed
Sep 9, 2024
Comment on lines
107
to
111
| normalizedDomain := u.Hostname() | ||
| if port := u.Port(); port != "" { | ||
| normalizedDomain += ":" + port | ||
| } | ||
| return normalizedDomain, nil |
There was a problem hiding this comment.
@fschade is that not part of any other PR? Related to the current breaking ocm setup in web?
There was a problem hiding this comment.
@butonic its a leftover from our early suggestion diff... can go away
There was a problem hiding this comment.
ok, dropped this and combinde the commits to glue the changelog to the change
Signed-off-by: Christian Richter <crichter@owncloud.com> add changelog Signed-off-by: Christian Richter <crichter@owncloud.com> Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
fix-ocm-share-updates
branch
from
d6fe3ed
to
925a643
Compare
butonic
approved these changes
Sep 9, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Allow update of ocm shares
We fixed a bug that prevented ocm shares to be updated or removed.
owncloud/ocis#9926