Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write upload session info atomically #4850

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 18, 2024

We now use a lock and atomic write on upload session metadata to prevent empty reads. A virus scan event might cause the file to be truncated and then a finished event might try to read the file, just getting an empty string.

@butonic butonic requested review from a team, labkode and glpatcern as code owners September 18, 2024 10:15
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a ocis pipeline for this? It locks stuff.

@butonic butonic force-pushed the write-upload-sessions-atomically branch 3 times, most recently from 5be5336 to 2d5c1dd Compare September 18, 2024 12:15
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Contributor Author

butonic commented Sep 18, 2024

@butonic
Copy link
Contributor Author

butonic commented Sep 18, 2024

ocis pr is green

@butonic butonic merged commit 5a494dc into cs3org:edge Sep 18, 2024
10 checks passed
@butonic butonic deleted the write-upload-sessions-atomically branch September 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants