WIP: add option to disable versioning in EOS upon PUT request #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
force-pushed
the
feature/disable-versioning
branch
2 times, most recently
from
41e988f
to
a1186bd
Compare
jessegeens
force-pushed
the
feature/disable-versioning
branch
from
b3c36b5
to
6b99f2e
Compare
diocas
requested changes
Oct 3, 2024
There was a problem hiding this comment.
First commit! Thanks.
I've made some comments. Please clean up the commit history to split the feature (and its tests) and all the other things you had to do to be able to do the tests (like updates and registering the gw?).
I'm not able to evaluate if the tests are ok like this. I'll wait for more knowledgeable people.
jessegeens
force-pushed
the
feature/disable-versioning
branch
6 times, most recently
from
b7a8ad1
to
0a396f9
Compare
diocas
reviewed
Oct 4, 2024
jessegeens
force-pushed
the
feature/disable-versioning
branch
3 times, most recently
from
c218967
to
63387a0
Compare
diocas
previously approved these changes
Oct 4, 2024
jessegeens
force-pushed
the
feature/disable-versioning
branch
from
63387a0
to
50d93c7
Compare
jessegeens
force-pushed
the
feature/disable-versioning
branch
2 times, most recently
from
a801001
to
287333f
Compare
jessegeens
force-pushed
the
feature/disable-versioning
branch
2 times, most recently
from
2360468
to
f04100c
Compare
diocas
reviewed
Oct 28, 2024
| @@ -278,6 +278,9 @@ func (s *svc) handlePut(ctx context.Context, w http.ResponseWriter, r *http.Requ | |||
| httpReq.Header.Set(HeaderLockHolder, lockholder) | |||
| } | |||
|
|
|||
| // Set Content-Length | |||
There was a problem hiding this comment.
I wonder if we should add a few more comments here. The bug in EOS is fixed, but it's still recommended to always pass the length.
| @@ -26,6 +26,7 @@ import ( | |||
| "strconv" | |||
|
|
|||
| provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1" | |||
| "github.com/cs3org/reva/internal/http/services/owncloud/ocdav" | |||
There was a problem hiding this comment.
Conceptually, do you thing ocdav is the correct place to have the content length header? It seems to be that it should be in some less specific place, used both inside the ocdav code and here.
jessegeens
force-pushed
the
feature/disable-versioning
branch
from
f04100c
to
9da5c22
Compare
added 3 commits
October 29, 2024 16:04
Implemented a new function to register a GatewayServiceClient. Previously, this could only be done by passing an actual connection. However, that is unnecessarily limiting. Introducing the RegisterGatewayServiceClient allows us to register mocked gateways for unit testing
This commit introduces a new header, `X-Disable-Versioning`, that is available on PUT requests. This header will disable versioning for this file save if the storage backend is EOS. Additionally, this commit introduces two unit tests related to this functionality: - TestDisableVersioningLeadsToCorrectQueryParams: test whether disabling versioning leads to correct query parameteers for the EOS HTTP / GRPC client - TestDisableVersioningHeaderPassedAlong: test whether a header passed to the initial endpoint is propagated to the actual upload endpoint Finally, this commit also fixes a bug that was already present, where the app was not passed along in the case of token-based authz
jessegeens
force-pushed
the
feature/disable-versioning
branch
from
9da5c22
to
3c5e2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4855
This PR introduces a new HTTP header for PUT requests,
X-Disable-Versioning. When this header is added to a PUT request, the EOS storage driver will turn off versioning for this particular save. This is particularly useful for applications that perform automatic saves every x minutes: disabling versioning on these automatic saves ensures that the version history of these files is not polluted