Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Fix posixfs flakiness #4967

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

aduffeck
Copy link
Contributor

Fix posixfs flakiness

Copy link

update-docs bot commented Nov 21, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck aduffeck force-pushed the posixfs-flakiness branch 3 times, most recently from 058ee51 to 2487c82 Compare November 21, 2024 13:16
@aduffeck aduffeck changed the title Fix posixfs flakiness [tests-only] Fix posixfs flakiness Nov 21, 2024
@aduffeck aduffeck marked this pull request as ready for review November 21, 2024 13:39
@aduffeck aduffeck requested review from a team, labkode and glpatcern as code owners November 21, 2024 13:39
@aduffeck aduffeck force-pushed the posixfs-flakiness branch 2 times, most recently from 61920db to e3820f8 Compare November 21, 2024 13:59
@micbar
Copy link
Member

micbar commented Nov 21, 2024

@aduffeck Interesting. How did that fix it?

@aduffeck
Copy link
Contributor Author

@micbar the problem was that the integration tests create new users for each test, with different ids but the same username. That in return lead to the space roots having the same path according to the "users/{{.User.Username}}" path template, leading to clashes and confusion in the cache. With the "users/{{.User.Id.OpaqueId}}" template it is guaranteed that there's a clean state for each test run now.

@aduffeck aduffeck merged commit 43de17f into cs3org:edge Nov 21, 2024
9 of 10 checks passed
@aduffeck aduffeck deleted the posixfs-flakiness branch November 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants