on delete move file versions to the trashbin #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
fix/delete-file-versions
branch
3 times, most recently
from
c17351f to
180e494
Compare
C0rby
force-pushed
the
fix/delete-file-versions
branch
from
180e494 to
1041cfe
Compare
labkode
approved these changes
May 12, 2020
C0rby
added a commit
to owncloud/reva
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First naive implementation. Moves are not atomic so we could end up in an invalid state.
The owncloud storage driver will be deprecated soonish so we will live with the compromise for now.
Fixes owncloud/ocis-reva#94