Separate PROPFIND logic for Depth 1 and infinity #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to path concatenation broke some cross-storage cases. Since clients currently only use Depth 1, here we make sure that at least this works. For the infinity case, it is limited to single storage recursion for now.
This was referenced May 27, 2020
|
Important note: I chose to keep the Depth:infinity logic in place because we already have automated tests that rely on it to be able to verify results for unrelated scenarios. I don't want to disable those tests or rewrite them as it would be even more work. |
labkode
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to path concatenation broke some cross-storage cases.
Since clients currently only use Depth 1, here we make sure that at
least this works.
For the infinity case, it is limited to single storage recursion for
now.
This is a workaround to unblock the public shares PR by removing the regression from view: #681
I've tested the propfinds locally and they work with all depths, but I only tested single-storage as I don't have the env for cross-storage. Based on the knowledge in #681 (comment) we know that the depth-1 logic does work there.
@refs