Implementation of file operations in public folder shares #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inline return working upload spare a few allocations provide missing parameter on InitiateUpload single file publicly shared download working filename on single shared file apply @PVince81 patch take into account depth improve base logic resolve append not assigned to same destination variable disable gocritic for long ifElse chains
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Move all path translation logic into a single private method to make it easier to reuse.
Whenever the actual storage operation on the gateway fails, return a response to the caller including the error.
Remove code for non-working single file share implementation
This was referenced Jun 24, 2020
This was referenced Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaned up version of #872 and #822.
This PR implements the following file operations for public folder shares:
Please note that public file shares (sharing a single file by link) does not work here. Further work on single file shares will be done in #872.
@labkode as requested in #822 the logic is now going through the gateway.
@butonic @refs FYI