Fix file-descriptor leak #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clone client transport from http.DefaultTransport instead of creating a zeroed transport struct. With an empty timeout-struct all timeout-values are zeroed disabling some timeouts and TTLs. See https://golang.org/src/net/http/transpor.go#L194 and following.
IljaN
force-pushed
the
set_golang_default_timeouts
branch
from
54cfec2 to
99e82fc
Compare
|
@jasson99 please test this fix |
|
@IljaN nice catch, for long term I think we should avoid to rely on the default transport and always create it explicitly without relying on package variables. |
labkode
approved these changes
Jul 8, 2020
|
Merge after @jasson99 validates. |
|
Hatch 0.25, 150 Concurrent |
refs
approved these changes
Jul 8, 2020
| "github.com/cs3org/reva/pkg/token" | ||
| "github.com/pkg/errors" | ||
| "go.opencensus.io/plugin/ochttp" | ||
| ) | ||
|
|
||
| // GetHTTPClient returns an http client with open census tracing support. |
Yes agree! We just need to find or tune the right values for our use-case. For now I assumed that the go-lang selected defaults should suite us. Any proposals? Cloning from DefaultTransport will ensure that we will get defaults for new parameters which might get added in future versions of golang. |
|
@IljaN I tested with this fix and it works now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone client transport from http.DefaultTransport instead of creating a zeroed transport struct.
With an empty timeout-struct all timeout-values are zeroed disabling some timeouts and TTLs.
See https://golang.org/src/net/http/transport.go#L194 and following.
Closes owncloud/product#100