OCS share fix including file info after update #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating a user share, the file information was missing from the response. This fix makes a stat call before returning the response to properly populate the file_source and other fields.
3 tasks
labkode
approved these changes
Jul 9, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating a user share, the file information was missing from the
response. This fix makes a stat call before returning the response to
properly populate the file_source and other fields.
Fixes owncloud/ocis-reva#332
Tested manually by looking at the network console in the browser after editing a user share.
Before this fix: the fields files_source and a few others were empty.
After this fix: the file id appears there in base64 form.