Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use _ for mapstructure #990

Merged
merged 1 commit into from
Jul 22, 2020
Merged

use _ for mapstructure #990

merged 1 commit into from
Jul 22, 2020

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jul 22, 2020

to align it with the other config options. no changelog needed as the original PR has a changelog and is unreleased.

to align it with the other config uptions. no changelog needed as the original PR has a changelog.
@butonic butonic requested a review from labkode as a code owner July 22, 2020 12:47
@update-docs
Copy link

update-docs bot commented Jul 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested a review from refs July 22, 2020 12:49
@butonic butonic self-assigned this Jul 22, 2020
@butonic butonic added the bug Something isn't working label Jul 22, 2020
@labkode labkode merged commit 6dea793 into cs3org:master Jul 22, 2020
@butonic butonic deleted the patch-4 branch July 22, 2020 13:06
@kulmann
Copy link
Member

kulmann commented Jul 23, 2020

post mortem: you could always add the url of a new PR to an existing (unreleased) changelog item, to make it more complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants