Optionally split space from endpoint #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging b280e69 into 2bf00ed - view on LGTM.com new alerts:
|
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> drop unused import Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
optionally-split-space-from-endpoint
branch
from
b280e69
to
55d1c8a
Compare
glpatcern
approved these changes
Jul 14, 2022
Not sure why this fires here, will review at a later stage |
|
@glpatcern I cleaned that up and force pushed. code is no longer importing string |
36 tasks
wkloucek
added a commit
to owncloud-devops/ocis-team-ocis
that referenced
this pull request
Jul 20, 2022
wkloucek
added a commit
to owncloud-devops/ocis-team-ocis
that referenced
this pull request
Jul 20, 2022
update wopiserver to get cs3org/wopiserver#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now optionally split the space id from the endpoint. This keeps the wopiserver compatible with reva master and reva edge, where we add the space id with: cs3org/reva#3074