Skip to content

Commit

Permalink
Merge pull request #133 from cs50/docker-outside-of-docker
Browse files Browse the repository at this point in the history
relocated docker-outside-of-docker feature to Dockerfile
  • Loading branch information
rongxin-liu authored Jan 4, 2024
2 parents df06d4b + 893981d commit d35dfa1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 5 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,10 @@ RUN chmod a+rx /opt/cs50/bin/* && \
RUN echo "if [ -z \"\$_PROFILE_D\" ] ; then for i in /etc/profile.d/*.sh; do if ["$i" == "/etc/profile.d/debuginfod*"] ; then continue; fi; . \"\$i\"; done; export _PROFILE_D=1; fi"


# Bake docker-outside-of-docker into image itself rather than install feature during codespaces' creation
# https://github.com/devcontainers/features/tree/main/src/docker-outside-of-docker
RUN curl --location --show-error --silent https://raw.githubusercontent.com/devcontainers/features/main/src/docker-outside-of-docker/install.sh | bash


# Set user
USER ubuntu
3 changes: 0 additions & 3 deletions devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,6 @@
}
}
},
"features": {
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {}
},
"forwardPorts": [
5000, /* Flask */
5900, /* VNC server */
Expand Down

0 comments on commit d35dfa1

Please sign in to comment.