issue238 fix #295
Merged
issue238 fix #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows check50 to catch wrong .randrange/.randint before it becomes disastrous
|
Fixes #238 |
rongxin-liu
approved these changes
Jan 26, 2025
| @check50.check(test_valid_level) | ||
| def test_random(): | ||
| """Little Professor generates random numbers correctly""" | ||
| level = "1" |
There was a problem hiding this comment.
It is possible that some students might use random.randrange for levels 2 and 3 but not for level 1, and check50 would not be able to detect it. However, the likelihood of such a scenario is so low that it may not be worth the effort to check all levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows check50 to catch wrong .randrange/.randint before it becomes pedagogically disastrous