Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up reference domain dependency in gmem consumer indexing #1735

Merged
merged 20 commits into from
Jun 25, 2022

Conversation

shmsong
Copy link

@shmsong shmsong commented May 26, 2022

No description provided.

Copy link
Owner

@csarofeen csarofeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment on magic zero.

Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Just some minor comments.

torch/csrc/jit/codegen/cuda/lower_index_hoist.h Outdated Show resolved Hide resolved
torch/csrc/jit/codegen/cuda/index_compute.cpp Outdated Show resolved Hide resolved
torch/csrc/jit/codegen/cuda/lower_index_hoist.h Outdated Show resolved Hide resolved
Base automatically changed from gmem_consumer_no_ref to alloc_idx_val June 24, 2022 23:21
shmsong and others added 4 commits June 24, 2022 16:22
Co-authored-by: Naoya Maruyama <naoyam@users.noreply.github.com>
Co-authored-by: Naoya Maruyama <naoyam@users.noreply.github.com>
Co-authored-by: Naoya Maruyama <naoyam@users.noreply.github.com>
@shmsong shmsong changed the title WIP : Clean up reference domain dependency in gmem consumer indexing Clean up reference domain dependency in gmem consumer indexing Jun 24, 2022
@shmsong shmsong merged commit 494294f into alloc_idx_val Jun 25, 2022
@shmsong shmsong deleted the gmem_consumer_cleanup branch June 25, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants