Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iterdomain graph to index non-global consumers #1737

Merged
merged 24 commits into from
Jun 25, 2022

Conversation

shmsong
Copy link

@shmsong shmsong commented May 27, 2022

No description provided.

Copy link
Owner

@csarofeen csarofeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -528,6 +529,77 @@ class PreferredPathCompute : public IterVisitor {
return compute.preferred_path;
}
};

class LoopIndexingPreferredPathCompute : public IterVisitor {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment this class as we'll remove the other variant that has comments.

Base automatically changed from gmem_consumer_cleanup to alloc_idx_val June 25, 2022 00:54
@shmsong shmsong changed the title WIP: use iterdomain graph to index non-global consumers Use iterdomain graph to index non-global consumers Jun 25, 2022
@shmsong shmsong merged commit e89071a into alloc_idx_val Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants