Remove reference tensor creation in producer tensor indexing path #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en/pytorch into gmem_consumer_cleanup
…een/pytorch into nonglobal_consumer_index
…rofeen/pytorch into producer_indexing_refactor
csarofeen
approved these changes
Jun 20, 2022
| @@ -151,6 +165,32 @@ IndexingParameters getGlobalIndexParameters( | |||
| loop_indexing.loopDomains(), | |||
| index_parameters.initial_concrete_id_index); | |||
|
|
|||
| // Setup double buffer increment for producer case: | |||
There was a problem hiding this comment.
I don't remember the double buffering part of indexing. @naoyam could you double check the double buffering portions of the changes in this PR stack.
There was a problem hiding this comment.
This is just incrementing producer index by one on the main stage of double buffer loop, if the consumer is double buffered, i.e. prefetching. We can now make the logic more explicit.
Will do that in a follow up as the merged PR is already getting huge.
There was a problem hiding this comment.
That's right. double_buffer_loop is a loop that's double buffered in the current loop nest. We can just skip the rest if it's nullptr.
shmsong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER